Skip to content

[tizen_app_manager] Remove Ecore API#1037

Merged
JSUYA merged 1 commit into
flutter-tizen:masterfrom
JSUYA:remove-ecore-tizen-app-manager
Jun 18, 2026
Merged

[tizen_app_manager] Remove Ecore API#1037
JSUYA merged 1 commit into
flutter-tizen:masterfrom
JSUYA:remove-ecore-tizen-app-manager

Conversation

@JSUYA

@JSUYA JSUYA commented Jun 16, 2026

Copy link
Copy Markdown
Member

Replace the Ecore main-loop and timer APIs with their GLib APIs.

flutter-tizen/embedder#146

@JSUYA JSUYA self-assigned this Jun 16, 2026
@JSUYA JSUYA added the enhancement New feature or request label Jun 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tizen_app_manager package to version 0.2.4. The changes replace the usage of the Ecore thread API (ecore_thread_run) with GLib threads (g_thread_try_new) in tizen_app_manager_plugin.cc for retrieving installed applications asynchronously. It also includes error handling for thread creation and updates the associated documentation and configuration files (CHANGELOG.md, README.md, and pubspec.yaml). There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Replace ecore_thread_run in GetInstalledApps with a GLib worker thread created via g_thread_try_new.
@JSUYA JSUYA force-pushed the remove-ecore-tizen-app-manager branch from e8c578f to da9e167 Compare June 18, 2026 05:56
@JSUYA JSUYA merged commit 4423cc4 into flutter-tizen:master Jun 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants